Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for classic themes using default presets #38701

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix for classic themes using default presets #38701

merged 1 commit into from
Feb 10, 2022

Conversation

oandregal
Copy link
Member

This PR ports the changes merged in WordPress core at WordPress/wordpress-develop#2233 so Gutenberg code for WordPress 5.9 and WordPress 5.9 repository are the same.

@oandregal oandregal requested review from jorgefilipecosta, a team and ellatrix and removed request for a team February 10, 2022 11:51
@oandregal oandregal self-assigned this Feb 10, 2022
@oandregal oandregal added Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 10, 2022
ntsekouras
ntsekouras approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

aristath
aristath approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oandregal oandregal merged commit af2d4df into trunk Feb 10, 2022
@oandregal oandregal deleted the fix/for-classic-themes-theme-json branch February 10, 2022 15:11
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 10, 2022
@oandregal oandregal mentioned this pull request Feb 10, 2022
Merged
@oandregal
Copy link
Member Author

Follow-up #38711

@youknowriad youknowriad added Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core and removed Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release labels Feb 10, 2022
@ajlende ajlende mentioned this pull request Feb 11, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@aristath aristath aristath approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix was automatically assigned from WordPress/gutenberg-core

Assignees

@oandregal oandregal

Labels
Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Milestone
Gutenberg 12.7
Development

Successfully merging this pull request may close these issues.
4 participants
@oandregal @aristath @ntsekouras @youknowriad